PIBD: bound segment decoding allocations#3850
Merged
Merged
Conversation
wiesche89
added a commit
that referenced
this pull request
Jun 12, 2026
* pibd: bound segment decoding allocations (#3850) * Add fountainoffairfortune seeds * Clarifies the blinding factor range proof explanation and includes the remaining typo fixes (#3840) * Bump version to v5.4.1 * PIBD peers fix (#3823) * pibd: choose peers based on minimal height, temporary block peers for stale segments disconnecting only outbound, force request for output and rangeproof segments to avoid stuck at this case * fix: add missing method clear_pibd_requests to commit * peer: block only non-blocked to not increase times for several requests * p2p: ignore last connection attempt when there is not enough outbound peers * pibd: do not check for max cached segments on selecting next desired segment for request * pibd: check if segment not exists at request when selecting next required * fix: add segment to request if not exists * fix: peers iterator to unblock blocked * peers: keep blocked list into memory till restart or pibd finish * sync: blocked filter * lmdb: do not include blocked peers in selection of peer, count also blocked peers to use fallback .zip download * pibd: increase timeout for .zip fallback * merge master into staging --------- Co-authored-by: David Burkett <davidburkett38@gmail.com> Co-authored-by: ardocrat <ardocrat@gri.mw>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cap PMMR segment and segment proof item counts before allocation, and avoid pre-allocating vectors from attacker-controlled counts.
Validate bitmap segment shape before allocation/conversion by rejecting empty blocks, oversized heights/block counts, and offset overflow. Use the fallible bitmap conversion on the P2P receive path so malformed
OutputBitmapSegmentmessages fail cleanly.Add regression coverage for the oversized segment and malformed bitmap segment cases.