Skip to content

use numeric constants #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wtholliday wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use numeric constants #4

wtholliday wants to merge 1 commit into from

Conversation

@wtholliday
Copy link
Contributor

@wtholliday wtholliday commented Sep 5, 2025

Minor cleanup :)

@mindbrix
Copy link
Owner

mindbrix commented Sep 5, 2025

Thanks. Can we define these using constexpr float instead? More consistent.

@wtholliday
Copy link
Contributor Author

wtholliday commented Sep 6, 2025 •
edited
Loading

I wanted to be absolutely sure I wasn't adding things in the constant memory space. MSL requires program scope constants to be declared as constexpr constant, though they'll probably optimized as inline constants. (Also the built-in numeric constants like M_SQRT2_F are expressed using macros)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtholliday @mindbrix