Skip to content

App default NULL config throws a warning  #3

Closed

Description

@lotfio

using the example given in the README.md to start minicli. I had the following error:

image

This is because you are appending a null to the config array by default and no config is passed when instantiating.

image

using an empty array as a default value solves the problem and suites better as the type hint is an array

image

Activity

  1. erikaheidi commented on May 26, 2020

    @erikaheidi
    Member

    hey @lotfio , you're right! Thanks for flagging that. Would you like to send a PR? I can totally understand if you don't have time right now, just let me know :) I just want to make sure I give space for people to collaborate if they want!

    cheers :)

  2. erikaheidi commented on May 26, 2020

    @erikaheidi
    Member

    Hey! As this is really breaking stuff, I will give it a go now so I can get it fixed before sharing the new documentation website. I would like to welcome you, thou, to stick around and maybe contribute with some other issue you might probably find later :D

  3. lotfio commented on May 26, 2020

    @lotfio
    MemberAuthor

    I was about to make a PR :) thanks for your feedback anyways.
    i would suggest adding a CONTRIBUTE.md to clarify some contribution guidelines thanks

  4. erikaheidi commented on May 26, 2020

    @erikaheidi
    Member

    That's a great suggestion, thank you! Will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions