Remove unencrypted git protocol use, as it will be disabled march 15th#1100
Merged
lantz merged 1 commit intomininet:masterfrom Feb 24, 2022
Merged
Conversation
Because Github removes support for unencrypted git protocol in March 2022, URLs in scripts are changed to use https. See https://github.blog/2021-09-01-improving-git-protocol-security-github/ for details
Member
|
As much as I prefer |
Contributor
Author
|
Is there something I still need to do before this can be merged? March 15th is approaching quickly :) |
lantz
approved these changes
Feb 24, 2022
Member
|
For some reason I couldn't easily get the CI to run, which means that the PR's checks didn't pass. However this looks fine. |
Telluur
pushed a commit
to Telluur/mininet
that referenced
this pull request
Mar 18, 2022
Because Github removes support for unencrypted git protocol in March 2022, URLs in scripts are changed to use https. See https://github.blog/2021-09-01-improving-git-protocol-security-github/ for details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just got hit by GitHub's current brownout of unencrypted git protocol usage when trying to install Mininet from source.
As usage of the unencrypted git protocol will be retired permanently on March 15th, I am submitting this patch changing the URLs to https instead.
For details, please see https://github.blog/2021-09-01-improving-git-protocol-security-github/
Cheers :)
Andreas