auto-detect python virtual environment#1235
Open
lorepap wants to merge 1 commit into
Open
Conversation
Akira1906
reviewed
Mar 2, 2025
There was a problem hiding this comment.
I've had a similar issue using mininet, I think this change definitely deserves a check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current installation script for Ubuntu distributions doesn't support installing mininet within a python virtual environment. The solution would be setting the PYTHON path to the current python venv, then running the script.
Also, when trying to install mininet with sudo permissions the system defaults to the system's python. It need some adjustment to the python path of the root user.
I've added a python virtual environment auto-detection - for a regular user - to the install.sh script to address the issue. Tested on Ubuntu 20.04 distro and python3-venv.