Adding: latency test, more control, more stats, etc..#9
Merged
Conversation
harshavardhana
requested changes
Jul 8, 2024
klauspost
reviewed
Jul 9, 2024
klauspost
approved these changes
Jul 10, 2024
harshavardhana
requested changes
Jul 10, 2024
harshavardhana
requested changes
Jul 10, 2024
harshavardhana
left a comment
Member
There was a problem hiding this comment.
will test this tomorrow in our DC across 8 nodes
harshavardhana
left a comment
Member
There was a problem hiding this comment.
can you remove binary from the commit? and also the hosts.txt file?
squash removing hosts
Contributor
Author
|
:S the hosts.txt was meant to be an example for a host file, but np. I'll remove it and the binary.. I don't know how that got in there. I squashed it all into one commit @harshavardhana |
harshavardhana
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Latency testing only
Using the flag
-latencyTestis a shortcut for a 60 second low-bandwidth latency test @guptaarvindkNotes
The
-severIPcan be used to define a server IP if two or more hosts are on the same machine. Technically this won't be needed to client deployments. We also introduce a check for the real remote IP incase clients are using proxies or LB's. The real IP is hidden if it's the same as the reported one.Additionally, error counts and latest error message for each 1 second increments were added just so we can see if something is going wrong without the entire window spamming in errors. There is a flag
-printAllwhich can be enabled to print all errors.┌───────────┬───────────┬──────┬──────────┬───────┬──────────┬─────────────┬───────────────┬─────────┬────────────┐ │ Local │ Remote │ RX # │ RX │ TX # │ TX │ MS high/low │ TTFB high/low │ Error # │ Last Error │ │ 127.0.0.1 │ 127.0.0.1 │ 9945 │ 6.5 GB/s │ 25503 │ 6.7 GB/s │ 27/0 │ 17/0 │ 0 │ │ └───────────┴───────────┴──────┴──────────┴───────┴──────────┴─────────────┴───────────────┴─────────┴────────────┘