helm: implement imagePullSecrets and add missing Job pod labels#462
Merged
harshavardhana merged 1 commit intoFeb 27, 2026
Merged
Conversation
imagePullSecrets was declared in values.yaml but never referenced in any template, silently ignoring the value for private registries. Also, the Job pod template was missing standard selector labels that the StatefulSet already had.
There was a problem hiding this comment.
Pull request overview
This pull request fixes two issues in the Warp Helm chart: implementing the previously unused imagePullSecrets field and ensuring Job pods always have proper selector labels. The imagePullSecrets field was declared in values.yaml but never referenced in the templates, preventing users with private registries from pulling images. Additionally, Job pod template metadata was only emitted conditionally when restartOnUpgrade was true, leaving pods without selector labels in other cases.
Changes:
- Implemented
imagePullSecretssupport in both StatefulSet and Job pod specs using the standard Helmwithpattern - Fixed Job pod template metadata to always include selector labels, moving them outside the
restartOnUpgradeconditional block
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| k8s/helm/templates/statefulset.yaml | Added imagePullSecrets block to pod spec with proper conditional rendering |
| k8s/helm/templates/job.yaml | Added imagePullSecrets block and fixed pod metadata to always include selector labels |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imagePullSecretsin bothjob.yamlandstatefulset.yaml. This value was declared invalues.yamlbut never referenced in any template, silently ignoring it for users with private registriesmetadataconditionally (whenrestartOnUpgradewas true), leaving pods unlabeled otherwiseTest plan
helm lint k8s/helm/passeshelm templatewithimagePullSecretsset renders the field in both Job and StatefulSethelm templatewith default values omitsimagePullSecrets(empty list)restartOnUpgradesetting