feat(http): allow error hook to override 502 responses #7999
+378
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a ResponseProtocolError occurs (e.g., upstream connection failure), addons can now set flow.response in the error hook to serve a custom response instead of the default 502 error. This enables common use cases like: - Serving cached responses when upstream is unavailable - Implementing circuit breaker patterns with fallback responses - Providing custom error pages instead of generic 502 errors - Graceful degradation during network failures Implementation details: - Tracks whether response was set before or during the error hook - Only applies override when response is newly set in the hook - Sets proper timestamps on the override response - Uses raw_content for consistency with send_response() - Handles trailers correctly - Works across HTTP/1.1, HTTP/2, and HTTP/3 Tests added for all three HTTP versions covering both the override case and the default behavior case.
fc35690 to
bf24944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ResponseProtocolError occurs (e.g., upstream connection failure), addons can now set flow.response in the error hook to serve a custom response instead of the default 502 error.
This enables common use cases like:
Implementation details:
Tests added for all three HTTP versions covering both the override case and the default behavior case.
Description
Checklist