Skip to content

suggest.deny filter change no longer matches docs and breaks deny() #40

Open

Description

@nevf

The commit bcf518b changed the blacklist deny test from < to <= which disagrees with the docs http://mixu.net/minilog/filter.html

This configures the default filter to hide logs where the level is < 'warn'. 

I don't understand why this change was made as you can no longer use:

Minilog.suggest.deny(/mymodule\/.*/, 'debug');

to filter out debug items etc.

Activity

  1. roark commented on Feb 7, 2019

    @roark
    Contributor

    The documentation is out of date but the ability to deny debug logs should still work.

    Currently:
    filter.deny() will deny the log level specified and below.
    filter.allow() will allow the log level specified and above.

    The code given should work, I've tested it locally and able to deny debug level logs. Can you post an example of the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions