Skip to content

Fix build without GoogleTest and Benchmark (#15727) #15736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
koushikcs562 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix build without GoogleTest and Benchmark (#15727) #15736

koushikcs562 wants to merge 2 commits into from

Conversation

@koushikcs562
Copy link

@koushikcs562 koushikcs562 commented Dec 11, 2025

Wrap find_package(benchmark) in if(BUILD_BENCH) to remove CMake warning

Wrap #include <gtest/gtest_prod.h> in #ifdef BUILD_TESTING to prevent compilation errors

All fixes tested locally

@JoergAtGithub
Copy link
Member

JoergAtGithub commented Dec 11, 2025

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

JoergAtGithub
JoergAtGithub reviewed Dec 11, 2025
View reviewed changes
JoergAtGithub
JoergAtGithub requested changes Dec 11, 2025
View reviewed changes
Copy link
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like yo accidentally commited two additional files

@koushikcs562
Copy link
Author

koushikcs562 commented Dec 11, 2025

It looks like yo accidentally commited two additional files

Yes I will remove them

@koushikcs562 koushikcs562 force-pushed the fix-build-without-gtest branch from 099917e to 70c5e61 Compare December 11, 2025 09:57
@daschuer
Copy link
Member

daschuer commented Dec 11, 2025

I am afraid this is not yet working.
You need to define

add_compile_definitions(BUILD_TESTING)

to have that available in the C++ code.
Can you please add another Draft PR for testing only, that covers the No-Google-Test case?

This can be done by removing

and adding
-DBUILD_TESTING=OFF
here:
https://github.com/daschuer/mixxx/blob/8720b7595fbbecd62d20c89bf66ff500adce5408/.github/workflows/build.yml#L59

@koushikcs562
Copy link
Author

koushikcs562 commented Dec 11, 2025

@daschuer sure i will

@daschuer daschuer mentioned this pull request Dec 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoergAtGithub JoergAtGithub JoergAtGithub requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

build controller backend engine library scanner soundsource sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koushikcs562 @JoergAtGithub @daschuer