importmaildir: sort messages by date first#351
Open
diresi wants to merge 1 commit into
Open
Conversation
maildir messages usually have timestamps in their filename indicating the `received` date, if that's not the case mtime is used. since we cannot assume the order of `ReadDir()` entries we have to read all entries and sort them accordingly first. fixes mjl-#341
d316706 to
0a463f1
Compare
Author
|
How about this? Does this look meaningful? And Golang-ish enough? |
Owner
|
@diresi Thanks for the PR. Just wanted to let you know I did see it. I'm a bit busy, will get back to you about it. |
TheNotary
added a commit
to TheNotary/mox
that referenced
this pull request
Apr 13, 2026
mjl-#345 Auto-generate DKIM keys in Mox Helm chart When dkim.autoGenerate.enabled is true and domains have no explicit DKIM keys, a pre-install/pre-upgrade hook Job generates ed25519 + RSA key pairs and stores them in a persistent Kubernetes Secret. Changes: - mjl-#346 Add dkim.autoGenerate values block and helper templates - mjl-#347 Create DKIM keygen RBAC (ServiceAccount, Role, RoleBinding) - mjl-#348 Create keygen ConfigMap (generate-dkim.sh) and Job hook - mjl-#349 Modify secret.yaml to conditionally skip inline DKIM keys - mjl-#350 Change deployment DKIM volume to projected volume - mjl-#351 Refactor DNS hook to read generated public keys at runtime - Fix pre-existing bug: deployment volume used list index instead of domain name Backward compatible — dkim.autoGenerate.enabled defaults to false. Precedence: inline privateKey > existingSecret > autoGenerate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maildir messages usually have timestamps in their filename indicating
the
receiveddate, if that's not the case mtime is used.since we cannot assume the order of
ReadDir()entries we have to readall entries and sort them accordingly first.
fixes #341