imapserver: emit a single untagged SEARCH response instead of chunking by 100#431
Open
pzeinlinger wants to merge 1 commit into
Open
imapserver: emit a single untagged SEARCH response instead of chunking by 100#431pzeinlinger wants to merge 1 commit into
pzeinlinger wants to merge 1 commit into
Conversation
…g by 100 RFC 3501 specifies one untagged SEARCH response per command, but mox was splitting the result into multiple lines of 100 UIDs. Clients built on emersion/go-imap (e.g. aerc) only retain the last untagged SEARCH, so mailboxes with more than 100 matches appeared truncated. Fixes mjl-#389. Also collapses MODSEQ to a single emission per response, matching RFC 7162's "for all messages being returned" wording.
fa5285f to
487d091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
* SEARCHresponse per command, but mox was splitting results into multiple lines of 100 UIDs.emersion/go-imap(e.g. aerc) only retain the last untagged SEARCH, so mailboxes with more than 100 matches appeared truncated. Fixes IMAP SEARCH results in multiple responses is a bug #389.Test plan
TestSearchSingleResponseappends 101 messages and asserts a singleUntaggedSearchevent covering all UIDs (red against the old chunked code).mox@localhost, ranUID SEARCH ALLand confirmed a single* SEARCHline.