Skip to content

chore(back): fix dependencies version #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

chore(back): fix dependencies version #959

merged 1 commit into from
Nov 4, 2025
+70 −55

Conversation

@SaboniAmine
Copy link
Member

@SaboniAmine SaboniAmine commented Nov 4, 2025

Description

Recompiled API requirements to fix the deployment issue, caused by an outdated fastapi-pagination version.

Related Issue

Motivation and Context

FastAPI is now in version 0.121.0 and matches Starlette constraints.

How Has This Been Tested?

Build & deployed on dev environment

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SaboniAmine SaboniAmine requested a review from a team as a code owner November 4, 2025 08:23
@inimaz
Copy link
Collaborator

inimaz commented Nov 4, 2025

The issue comes from pinning starlette, I think :( FastAPI recommends to avoid pinning it https://fastapi.tiangolo.com/deployment/versions/#about-starlette

@SaboniAmine
Copy link
Member Author

SaboniAmine commented Nov 4, 2025 •
edited
Loading

Actually Starlette is not directly referenced in the pyproject.toml, which is the source of the requirements-api.txt file (used for the clever install).
Because fastapi-pagination was stuck to 0.9.1, it was asking for an older version of fastapi, asking for a starlette version incompatible with previous compilation, see logs:

2025-11-04T09:03:02.627+01:00 ERROR: Cannot install -r ../requirements/requirements-api.txt (line 41) and starlette==0.49.1 because these package versions have conflicting dependencies.
2025-11-04T09:03:02.628+01:00 The conflict is caused by:
2025-11-04T09:03:02.628+01:00     The user requested starlette==0.49.1
2025-11-04T09:03:02.628+01:00     fastapi 0.116.1 depends on starlette<0.48.0 and >=0.40.0

Unlocking fastapi-pagination solved the compilation of the correct set of dependencies.

@inimaz
Copy link
Collaborator

inimaz commented Nov 4, 2025

Nice thanks! This is the culprit 🕵️ b2060c5 😄 We should not update starlette on its own

inimaz
inimaz approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@inimaz inimaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @SaboniAmine!

@inimaz inimaz merged commit 5718b3c into master Nov 4, 2025
11 checks passed
@inimaz inimaz deleted the chore/fix_api_dependencies_versions branch November 4, 2025 08:45
@SaboniAmine
Copy link
Member Author

SaboniAmine commented Nov 4, 2025

Thanks detective Inigo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inimaz inimaz inimaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaboniAmine @inimaz