Added mask to SSIM function call #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the mask should also be provided to the SSIM function call. As the mask variable is always present/valid (either a proper mask if provided by the user or all-ones, see variable initialisation), it should be fine to simply add the mask as parameter to the call.
In my opinion, structural_similarity_index() should work fine with this additional parameter and nothing should break. However, I did not test the suggested code change.
This really is just a very minor change so please don't be mad at me for not following the standard PR procedure UwU
Proposed Changes
Checklist
CONTRIBUTINGguide.