Skip to content

Conversation

@hasan7n
Copy link
Contributor

@hasan7n hasan7n commented Aug 9, 2023

The aim is to have flexibility in creating model MLCubes from GaNDLF models. The user can now provide a custom entrypoint script for the MLCube which can act as a wrapper around calling gandlf_run. The goal is to NOT rely on having data input folder containing a csv file. Using a custom script, the model author can build a csv file before calling gandlf_run.

Proposed Changes

  • Modify gandlf_deploy to allow custom entrypoint scripts for model deploy (like what we have for metrics deploy)
  • add CI tests for deploy ( model + metrics deploy) and running the resulting MLCubes.

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@hasan7n hasan7n requested a review from sarthakpati August 9, 2023 13:05
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #711 (60f35d0) into master (616b37b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   94.71%   94.72%   +0.01%     
==========================================
  Files         117      117              
  Lines        8243     8251       +8     
==========================================
+ Hits         7807     7816       +9     
+ Misses        436      435       -1     
Flag Coverage Δ
unittests 94.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
GANDLF/cli/deploy.py 90.59% <100.00%> (+1.12%) ⬆️
testing/test_full.py 99.16% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 32fd05c into mlcommons:master Aug 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants