Skip to content

Using tuples for PSNR datarange #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarthakpati merged 3 commits into from
Aug 10, 2023
Merged

Using tuples for PSNR datarange #712

sarthakpati merged 3 commits into from
Aug 10, 2023

Conversation

@FelixSteinbauer
Copy link
Contributor

@FelixSteinbauer FelixSteinbauer commented Aug 10, 2023

Fixes missing 0-1 range for the psnr_01_eps case (synthesis case).

Proposed Changes

  • Use tuple to indicate range (not just an float). This should be more intuitive.
  • Added the data_range to the psnr_01_eps case because it was missing there

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@FelixSteinbauer
Copy link
Contributor Author

FelixSteinbauer commented Aug 10, 2023

I really am sorry to bother you again. I hope this was the last PR from my side 🙈

@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR data_range not float. Added data_range to psnr_01_eps case (was missing there) Using tuples for PSNR data_range not float. Added data_range to psnr_01_eps case. It was missing there Aug 10, 2023
@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR data_range not float. Added data_range to psnr_01_eps case. It was missing there Using tuples for PSNR data_range not float Added data_range to psnr_01_eps case It was missing there Aug 10, 2023
@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR data_range not float Added data_range to psnr_01_eps case It was missing there Using tuples for PSNR datarange not float. Added data_range to psnr01eps case. It was missing there Aug 10, 2023
@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR datarange not float. Added data_range to psnr01eps case. It was missing there Using tuples for PSNR datarange not float. Added datarange to psnr01eps case. It was missing there Aug 10, 2023
sarthakpati
sarthakpati previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests.

@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR datarange not float. Added datarange to psnr01eps case. It was missing there Using tuples for PSNR datarange not float Added datarange to psnreps case Aug 10, 2023
@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR datarange not float Added datarange to psnreps case Using tuples for PSNR datarange. Adddatarange to psnr01eps case Aug 10, 2023
@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR datarange. Adddatarange to psnr01eps case Using tuples for PSNR datarange. Add datarange to psnr01eps case Aug 10, 2023
@FelixSteinbauer FelixSteinbauer changed the title Using tuples for PSNR datarange. Add datarange to psnr01eps case Using tuples for PSNR datarange Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #712 (24d175f) into master (d12ca21) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         117      117           
  Lines        8243     8243           
=======================================
  Hits         7807     7807           
  Misses        436      436
Flag Coverage Δ
unittests 94.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
GANDLF/cli/generate_metrics.py 100.00% <ø> (ø)
GANDLF/metrics/synthesis.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FelixSteinbauer
Copy link
Contributor Author

FelixSteinbauer commented Aug 10, 2023

Had to fix do a little fix to make the tests pass.

sarthakpati
sarthakpati approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 616b37b into mlcommons:master Aug 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FelixSteinbauer @sarthakpati