Skip to content

Minor code refactoring #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarthakpati merged 6 commits into from
Sep 8, 2023
Merged

Minor code refactoring #719

sarthakpati merged 6 commits into from
Sep 8, 2023

Conversation

@tosemml
Copy link
Contributor

@tosemml tosemml commented Sep 5, 2023 •
edited
Loading

Fixes #ISSUE_NUMBER

Proposed Changes

These slight code adjustments aim to enhance Pythonic quality by incorporating python str.join

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #719 (c0dd9ff) into master (d743d9c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c0dd9ff differs from pull request most recent head a76df1e. Consider uploading reports for the commit a76df1e to get more accurate results

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   94.71%   94.71%   -0.01%     
==========================================
  Files         117      117              
  Lines        8253     8251       -2     
==========================================
- Hits         7817     7815       -2     
  Misses        436      436
Flag Coverage Δ
unittests 94.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
GANDLF/logger.py 91.66% <100.00%> (-0.23%) ⬇️
GANDLF/utils/write_parse.py 96.62% <100.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

sarthakpati
sarthakpati approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! We should be good to merge once you have signed the CLA!

@tosemml
Copy link
Contributor Author

tosemml commented Sep 8, 2023

Thanks. I signed the CLA.

@sarthakpati sarthakpati changed the title Code refactoring Minor code refactoring Sep 8, 2023
@sarthakpati sarthakpati merged commit 60c9d28 into mlcommons:master Sep 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tosemml @sarthakpati