Skip to content

Upgrade base python and numpy versions #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarthakpati merged 19 commits into from
Nov 14, 2023
Merged

Upgrade base python and numpy versions #730

sarthakpati merged 19 commits into from
Nov 14, 2023

Conversation

@szmazurek
Copy link
Collaborator

@szmazurek szmazurek commented Nov 9, 2023

Fixes #726

Proposed Changes

  • changed required numpy version to 1.25.0
  • changed allowed python versions to 3.9 and 3.10
  • modified the workflows and Dockerfiles configuration to build and test against python3.9

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@szmazurek
Porting to Python 3.10 and numpy 1.25.0
daaf259 
- changed requirements in the setup.py to require proper Python and numpy versions
- the tests were ran for Python 3.9 and 3.10 versions, passed
- minor modifications in the code for numpy 1.25 type compatibility
@szmazurek
Python version fix
1798982
@szmazurek
Fix setup/classifiers Python version
fa838d6
@szmazurek
Upgrade python version
c19fcc1 
- changed versions in worflows .yml files to 3.9
- changed versions in Dockerfiles to 3.9
- changed versions in mlcube configs to 3.9
- /build folder remains unchanged for now
@szmazurek
Fix python3.9 setup
a7ead8f
@szmazurek
Dockerfile fix
1ef882d
@szmazurek
Dockerfile fix
e81b727
@szmazurek
Upgrade ubuntu version to 20.04
db6db1e
@szmazurek
Dockerfile fix
3f0a7db
@szmazurek
Update Dockerfiles
665164e 
- changed the ubuntu version to 20.04
- changed CUDA image to be compatibilie with ubuntu 20.04
@szmazurek
Update devcontainer Dockerfile
e0ba12f
@szmazurek
Fix libgl errors
509f2b0
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati
sarthakpati reviewed Nov 9, 2023
View reviewed changes
sarthakpati
sarthakpati reviewed Nov 9, 2023
View reviewed changes
sarthakpati
sarthakpati reviewed Nov 9, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (16f337e) 94.69% compared to head (5ba191e) 94.72%.

❗ Current head 5ba191e differs from pull request most recent head 25f90eb. Consider uploading reports for the commit 25f90eb to get more accurate results

Files Patch % Lines
GANDLF/cli/deploy.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   94.69%   94.72%   +0.02%     
==========================================
  Files         117      117              
  Lines        8221     8221              
==========================================
+ Hits         7785     7787       +2     
+ Misses        436      434       -2
Flag Coverage Δ
unittests 94.72% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati changed the title upgrade to python3.9/3.10 and numpy 1.25.0 Upgrade base python and numpy versions Nov 13, 2023
sarthakpati
sarthakpati requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested.

@sarthakpati sarthakpati mentioned this pull request Nov 13, 2023
Closed
sarthakpati
sarthakpati previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarthakpati
sarthakpati reviewed Nov 14, 2023
View reviewed changes
@sarthakpati sarthakpati disabled auto-merge November 14, 2023 15:56
@sarthakpati sarthakpati merged commit 4caedb5 into mlcommons:master Nov 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@szmazurek szmazurek deleted the feature/python_3_10_numpy_1_25 branch November 21, 2023 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New dependency versions (Pandas and PyTorch 2.0) need newer numpy

2 participants

@szmazurek @sarthakpati