Skip to content

Updated version for development #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Geeks-Sid merged 3 commits into from
Nov 13, 2023
Merged

Updated version for development #732

Geeks-Sid merged 3 commits into from
Nov 13, 2023

Conversation

@sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Nov 11, 2023 •
edited
Loading

Fixes #N.A.

Proposed Changes

  • version update for development

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited
Loading

Codecov Report

Merging #732 (f2be882) into master (a12b1b4) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   94.68%   94.69%   +0.01%     
==========================================
  Files         117      117              
  Lines        8221     8221              
==========================================
+ Hits         7784     7785       +1     
+ Misses        437      436       -1
Flag Coverage Δ
unittests 94.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
GANDLF/version.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Geeks-Sid Geeks-Sid merged commit 16f337e into mlcommons:master Nov 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@sarthakpati sarthakpati deleted the version_update branch November 13, 2023 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Geeks-Sid Geeks-Sid Geeks-Sid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarthakpati @Geeks-Sid