Upgrade base torchmetrics version #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added requirements in setup.py - modified the metrics constructors in the GANDLF.metrics.generic and .classification files to be compatibile with updated torchmetrics API - modified .yaml file to cover new fields compatibile with new torchmetrics API - defined utility functions for easier construction of metrics from new torchmetrics API
Feature/torchmetrics upgrade
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 94.69% 94.67% -0.03%
==========================================
Files 117 117
Lines 8224 8242 +18
==========================================
+ Hits 7788 7803 +15
- Misses 436 439 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sarthakpati
requested changes
Nov 20, 2023
Collaborator
sarthakpati
left a comment
There was a problem hiding this comment.
Minor changes requested. Additionally, Codacy errors [ref] need to be fixed as well:
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
codacy hotfix
Import Hotfix
Manually trigger this action
sarthakpati
reviewed
Nov 21, 2023
- removed redundant if-else statement - fixed bug with incorrect reading from the average_types_keys dictionary
- moved utility functions into utils.generic.py - simplified the creation of generic metrics - modified the usage docs to link to the current torchmetrics version docs
Feature/torchmetrics upgrade
sarthakpati
requested changes
Nov 22, 2023
Collaborator
sarthakpati
left a comment
There was a problem hiding this comment.
Requesting minor changes - check linting
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741
Proposed Changes
Checklist
CONTRIBUTINGguide.pip installstep is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].