Skip to content

Upgrade base PyTorch version #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarthakpati merged 10 commits into from
Nov 26, 2023
Merged

Upgrade base PyTorch version #747

sarthakpati merged 10 commits into from
Nov 26, 2023

Conversation

@szmazurek
Copy link
Collaborator

@szmazurek szmazurek commented Nov 23, 2023

Fixes #587

Proposed Changes

  • upgrading the Pytorch version to 2.1.0
  • modifying the workflows and containers appropriately

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@Geeks-Sid
Copy link
Collaborator

Geeks-Sid commented Nov 23, 2023

@sarthakpati Would you mind if i watch this PR?

@sarthakpati
Copy link
Collaborator

sarthakpati commented Nov 24, 2023

@sarthakpati Would you mind if i watch this PR?

Of course! Do you want to review it? Didn't know if you had the bandwidth so didn't assign to you.

@sarthakpati
Copy link
Collaborator

sarthakpati commented Nov 24, 2023

@aristizabal95 @hasan7n do you guys have any insight on the failing mlcube test? I'm unable to figure it out.

@hasan7n
Copy link
Contributor

hasan7n commented Nov 25, 2023

@sarthakpati the mlcube's dockerfile name should be changed to Dockerfile-CUDA11.8

GaNDLF/mlcube/model_mlcube/mlcube.yaml

Line 33 in 3ef60ff

build_file: "Dockerfile-CUDA11.6"

@szmazurek szmazurek closed this Nov 25, 2023
@szmazurek szmazurek reopened this Nov 25, 2023
@szmazurek
Copy link
Collaborator Author

szmazurek commented Nov 25, 2023

@sarthakpati the mlcube's dockerfile name should be changed to Dockerfile-CUDA11.8

GaNDLF/mlcube/model_mlcube/mlcube.yaml

Line 33 in 3ef60ff

build_file: "Dockerfile-CUDA11.6"

Thanks! Somehow missed that when running grep on the files. Made the modifications, on my forks all tests passed, waiting for the main ones to complete.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
sarthakpati
sarthakpati reviewed Nov 26, 2023
View reviewed changes
sarthakpati
sarthakpati requested changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested, and it should be good to go.

@sarthakpati sarthakpati changed the title Porting to Pytorch 2.1.0 Upgrade base PyTorch version Nov 26, 2023
@mlcommons mlcommons unlocked this conversation Nov 26, 2023
@sarthakpati sarthakpati merged commit b6a73fb into mlcommons:master Nov 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Porting to PyTorch 2.0

4 participants

@szmazurek @Geeks-Sid @sarthakpati @hasan7n