-
Notifications
You must be signed in to change notification settings - Fork 89
Removing double print of metrics #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Previous output: [SNIP!]
Looping over training data: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 19/19 [05:18<00:00, 16.74s/it]
Epoch Final train loss : 1.3392270615226345
Epoch Final train accuracy : 0.4290512204170227
Epoch Final train precision : 0.184084951877594
Epoch Final train recall : 0.4290512204170227
Epoch Final train f1 : 0.29341151197686005
Epoch Final train specificity : 0.5709487795829773
Epoch Final train aucroc : 0.5
Epoch Final train classification_accuracy : 0.36922233512527064
{'accuracy': 0.4290512204170227, 'precision': 0.184084951877594, 'recall': 0.4290512204170227, 'f1': 0.29341151197686005, 'specificity': 0.5709487795829773, 'aucroc': 0.5, 'classification_accuracy': 0.36922233512527064}
{'accuracy': 0.4290512204170227, 'precision': 0.184084951877594, 'recall': 0.4290512204170227, 'f1': 0.29341151197686005, 'specificity': 0.5709487795829773, 'aucroc': 0.5, 'classification_accuracy': 0.36922233512527064}
[SNIP!]After this PR: [SNIP!]
Looping over training data: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 19/19 [05:18<00:00, 16.74s/it]
Epoch Final train loss : 1.3392270615226345
Epoch Final train accuracy : 0.4290512204170227
Epoch Final train precision : 0.184084951877594
Epoch Final train recall : 0.4290512204170227
Epoch Final train f1 : 0.29341151197686005
Epoch Final train specificity : 0.5709487795829773
Epoch Final train aucroc : 0.5
Epoch Final train classification_accuracy : 0.36922233512527064
[SNIP!] |
sarthakpati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 122 122
Lines 8344 8344
=======================================
Hits 7935 7935
Misses 409 409
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #N.A.
Proposed Changes
Checklist
CONTRIBUTINGguide has been followed.typingis used to provide type hints, including and not limited to usingOptionalif a variable has a pre-defined value).pip installstep is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].