-
Notifications
You must be signed in to change notification settings - Fork 89
New command line API functionality #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #845 +/- ##
==========================================
- Coverage 95.04% 94.61% -0.44%
==========================================
Files 122 160 +38
Lines 8297 9450 +1153
==========================================
+ Hits 7886 8941 +1055
- Misses 411 509 +98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # GANDLF/entrypoints/__init__.py
# Conflicts: # GANDLF/entrypoints/__init__.py
# Conflicts: # GANDLF/entrypoints/__init__.py # GANDLF/entrypoints/verify_install.py
# Conflicts: # GANDLF/entrypoints/__init__.py
# Conflicts: # GANDLF/entrypoints/__init__.py # GANDLF/entrypoints/recover_config.py
# Conflicts: # GANDLF/entrypoints/__init__.py # GANDLF/entrypoints/construct_csv.py
# Conflicts: # GANDLF/entrypoints/__init__.py
# Conflicts: # GANDLF/entrypoints/__init__.py
# Conflicts: # GANDLF/entrypoints/__init__.py
# Conflicts: # GANDLF/entrypoints/verify_install.py
Adding proper parameter usage in the class constructor
|
@szmazurek I should have addressed all comments... |
mlcube/metrics_mlcube/example_custom_entrypoint/getting_started_3d_rad_seg.py
Outdated
Show resolved
Hide resolved
mlcube/model_mlcube/example_custom_entrypoint/getting_started_3d_rad_seg.py
Outdated
Show resolved
Hide resolved
szmazurek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor thing regarding logging levels and imo good to go
mlcube/metrics_mlcube/example_custom_entrypoint/getting_started_3d_rad_seg.py
Show resolved
Hide resolved
mlcube/model_mlcube/example_custom_entrypoint/getting_started_3d_rad_seg.py
Show resolved
Hide resolved
szmazurek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another remark regarding logging
Fixes #ISSUE_NUMBER
Major Changes
click, and related changes to workflows and testspipversions (Hardcoding pip version for workflows #887)Checklist
CONTRIBUTINGguide has been followed.typingis used to provide type hints, including and not limited to usingOptionalif a variable has a pre-defined value).pip installstep is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].