Skip to content

Conversation

@sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Apr 9, 2024

Fixes #ISSUE_NUMBER

Major Changes

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati marked this pull request as draft April 9, 2024 17:30
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 94.25386% with 67 lines in your changes missing coverage. Please review.

Project coverage is 94.61%. Comparing base (5e43783) to head (5652542).

Files Patch % Lines
testing/entrypoints/__init__.py 84.72% 22 Missing ⚠️
GANDLF/entrypoints/collect_stats.py 77.50% 9 Missing ⚠️
update_version.py 57.14% 9 Missing ⚠️
GANDLF/config_manager.py 64.70% 6 Missing ⚠️
GANDLF/data/augmentation/__init__.py 73.33% 4 Missing ⚠️
GANDLF/entrypoints/verify_install.py 86.95% 3 Missing ⚠️
GANDLF/entrypoints/construct_csv.py 96.49% 2 Missing ⚠️
GANDLF/entrypoints/optimize_model.py 93.10% 2 Missing ⚠️
GANDLF/cli/deploy.py 0.00% 1 Missing ⚠️
GANDLF/entrypoints/anonymizer.py 97.95% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   95.04%   94.61%   -0.44%     
==========================================
  Files         122      160      +38     
  Lines        8297     9450    +1153     
==========================================
+ Hits         7886     8941    +1055     
- Misses        411      509      +98     
Flag Coverage Δ
unittests 94.61% <94.25%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VukW and others added 27 commits April 10, 2024 12:37
# Conflicts:
#	GANDLF/entrypoints/__init__.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
#	GANDLF/entrypoints/verify_install.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
#	GANDLF/entrypoints/recover_config.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
#	GANDLF/entrypoints/construct_csv.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
# Conflicts:
#	GANDLF/entrypoints/__init__.py
# Conflicts:
#	GANDLF/entrypoints/verify_install.py
@sarthakpati
Copy link
Collaborator Author

@szmazurek I should have addressed all comments...

Copy link
Collaborator

@szmazurek szmazurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor thing regarding logging levels and imo good to go

Copy link
Collaborator

@szmazurek szmazurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another remark regarding logging

@sarthakpati sarthakpati disabled auto-merge July 31, 2024 14:19
@sarthakpati sarthakpati merged commit 90836cf into master Jul 31, 2024
@sarthakpati sarthakpati deleted the new-apis_v0.1.0-dev branch July 31, 2024 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants