Skip to content

Updated version check for nightly builds #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarthakpati merged 3 commits into from
Jul 27, 2024
Merged

Updated version check for nightly builds #910

sarthakpati merged 3 commits into from
Jul 27, 2024

Conversation

@sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Jul 26, 2024

Fixes #ISSUE_NUMBER

Proposed Changes

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati requested a review from a team as a code owner July 26, 2024 21:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title updated version check for nightly builds Updated version check for nightly builds Jul 26, 2024
@codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (ed8ad93) to head (cef43cc).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   95.05%   95.04%   -0.02%     
==========================================
  Files         122      122              
  Lines        8297     8297              
==========================================
- Hits         7887     7886       -1     
- Misses        410      411       +1
Flag Coverage Δ
unittests 95.04% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati enabled auto-merge July 26, 2024 23:44
szmazurek
szmazurek approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@szmazurek szmazurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 2695b06 into master Jul 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
@sarthakpati sarthakpati deleted the sarthakpati-patch-1 branch July 28, 2024 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szmazurek szmazurek szmazurek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarthakpati @szmazurek