Skip to content

Update sample configuration for classification #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarthakpati merged 1 commit into from
Aug 14, 2024
Merged

Update sample configuration for classification #917

sarthakpati merged 1 commit into from
Aug 14, 2024

Conversation

@scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Aug 14, 2024 •
edited
Loading

Fixes #ISSUE_NUMBER

Proposed Changes

  • the sample configuration for classification did not have the class_list, which is needed.

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@scap3yvt scap3yvt requested a review from a team as a code owner August 14, 2024 12:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (72bd1db) to head (376b8c2).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   94.61%   94.60%   -0.02%     
==========================================
  Files         160      160              
  Lines        9470     9470              
==========================================
- Hits         8960     8959       -1     
- Misses        510      511       +1
Flag Coverage Δ
unittests 94.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati merged commit cfbd863 into master Aug 14, 2024
@sarthakpati sarthakpati deleted the scap3yvt-patch-1 branch August 14, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scap3yvt @sarthakpati