Skip to content

Conversation

@scap3yvt
Copy link
Collaborator

Fixes #1013

Proposed Changes

  • added a new config to pass panoptica parameters
  • added associated docs

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner June 10, 2025 13:15
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati
Copy link
Collaborator

Would prefer to have @neuronflow to provide some feedback before merging.

@sarthakpati sarthakpati merged commit 7e81184 into mlcommons:master Jun 10, 2025
30 of 31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
@scap3yvt scap3yvt deleted the metrics_debugging branch June 11, 2025 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable passing custom panoptica configs for metrics

3 participants