Potential fix for code scanning alert no. 11: Incomplete URL substring sanitization #173
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
anandhu-eng
approved these changes
Sep 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mlcommons/mlcflow/security/code-scanning/11
To safely determine if the incoming
i_repo_pathpoints to GitHub, we should use URL parsing rather than substring matching. We should use Python's standard libraryurllib.parse.urlparseto parse the URL and then check if the hostname is exactly 'github.com' (or optionally any subdomain of GitHub, if desired). This fix is to replace the unsafe substring check with a parsed-host equivalence check. The code change is in the conditional at line 88, within theRepoAction.addmethod, and may require importingurlparsefromurllib.parseat the top of the file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.