Skip to content

Conversation

@tomerm-iguazio
Copy link
Contributor

@tomerm-iguazio tomerm-iguazio commented Dec 18, 2025

📝 Description

get_store_artifact in the Store Manager does not allow empty resources by default. This includes cases such as:

  • An empty target path for a PKL-based artifact
  • A missing model_uri (ModelArtifact) for an LLMPromptArtifact

🛠️ Changes Made

  1. Allow _get_artifact_object in the Model class to return artifacts with empty resources by passing allow_empty_resources=True.
  2. Raise an error if predict and async_predict are not overridden and there is no ModelArtifact.
  3. Fix all MLRunInvalidArgumentError raises (required dict instead of str)

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing


🔗 References

  • Ticket link: ML-11767
  • Design docs links:
  • External links:

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

Copy link
Contributor

@davesh0812 davesh0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments

@davesh0812 davesh0812 changed the title [Serving] Allow LLmodel + LLMPromptArtifact without ModelArtifact instance [Serving] Allow LLModel + LLMPromptArtifact without ModelArtifact instance Dec 18, 2025
@davesh0812 davesh0812 merged commit f72e4b6 into mlrun:development Dec 21, 2025
13 checks passed
tomerm-iguazio added a commit to tomerm-iguazio/mlrun that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants