reporters: rename xunit to junit, deprecate old xunit name#5875
reporters: rename xunit to junit, deprecate old xunit name#5875mostafaNazari702 wants to merge 1 commit into
Conversation
|
👋 Hi @mostafaNazari702, thanks for the pull request! A scan flagged a concern with it. Could you please take a look? [pr-task-completion] This PR's body is missing
Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5875 +/- ##
==========================================
+ Coverage 89.71% 89.72% +0.01%
==========================================
Files 64 65 +1
Lines 4695 4703 +8
Branches 978 978
==========================================
+ Hits 4212 4220 +8
Misses 483 483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The xunit reporter has always emitted JUnit-format XML (testsuite/testcase elements), not actual xUnit.net format. Fixes mochajs#4758. - adds a new junit reporter with all the same logic - turns xunit into a thin deprecation wrapper that extends JUnit - the deprecation goes through process.emitWarning so its suppressable with --no-warnings and wont spam CI stderr like console.warn would - updated docs and tests accordingly
8f28c92 to
e81fcfa
Compare
This concerns me.... |
| @@ -1,11 +1,22 @@ | |||
| --- | |||
| description: The XUnit test reporter for Mocha. | |||
There was a problem hiding this comment.
we'll probably redirect this page instead of adding a deprecation notice, it's just the doc site so "breaking changes" like a redirect are not actually a concern :)
|
Don't have energy to fully review right now, sorry, hopefully soon though :) we are still focusing on v12 and then I will set up a v13 branch for this to merge into :) |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM! A bit unfortunate we'll have to wait to merge this for a while (breaking change for v13).
| expectedWrite += str; | ||
| }); | ||
|
|
||
| //3 tests, no failures (i.e tests that could not run), and 2 errors |
There was a problem hiding this comment.
[Nit] Teeny nit, a few comments changed in the move. Did an AI agent have a hiccup or something? 🙂
| //3 tests, no failures (i.e tests that could not run), and 2 errors | |
| // 3 tests, no failures (i.e tests that could not run), and 2 errors |
There was a problem hiding this comment.
That was actually on me, i am using a different IDE on Arch Linux, and i sometimes run into graphics/rendering quirks (GPU-related as i have what is not "recommended" for ArchLinux) that make spacing look off. I removed what I thought was an extra space, but checking the PR now i see ( through my phone ) it was correct originally.
And regarding the AI use, I can see why it might come across that way from the templates/formattings on almost all my PRs/commits, but I’m not using AI to generate the code itself, just for comment and template generations and explaining my autistic thoughts 🙂
PR Checklist
status: accepting prsOverview
The
xunitreporter has always emitted JUnit XML (<testsuite>/<testcase>) rather than actual xUnit.net XML. This renames the reporter tojunitand turnsxunitinto a deprecated wrapper that emits aDeprecationWarningviaprocess.emitWarning(suppresible with--no-warnings).