test(integration): stabilize watch helper using run-completion sync#5879
test(integration): stabilize watch helper using run-completion sync#5879mostafaNazari702 wants to merge 1 commit into
Conversation
|
Wrong branch. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
=======================================
Coverage 80.85% 80.85%
=======================================
Files 64 64
Lines 4566 4566
Branches 958 958
=======================================
Hits 3692 3692
Misses 874 874 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I was actually right, thought that i pushed code to the previous active PR that i have. Sorry. |
8bb403d to
f755981
Compare
|
Nice, this could finally close that issue :) updated the branch to get another run to see if there is flakiness left, thank you :) |
|
@mostafaNazari702 the most recent CI run has integration failures |
…ad of fixed startup sleeps
62ee929 to
54dcfda
Compare
|
Accidental push without committing closed the PR, excuse me. |
PR Checklist
status: accepting prsOverview
This stabilizes
test/integration/options/watch.spec.jsby removing the brittle startup timing assumption inrunMochaWatchAsync.Before this change, helper timing was based on fixed sleeps (
sleepMs) before and after the file change callback. That could miss real watch lifecycle timing on slower/contended CI environments, especially for watch paths outside the current working directory.What changed:
runMochaWatchAsyncnow synchronizes using real watch-run completion markers from subprocess output instead of relying on fixed startup waits.SIGINT.Why this approach:
Validation run:
npm run test-node:integration:watch→30 passing--parallel --timeout 10000 --slow 3750, grep:outside the current working directory) passed consistently, including under CPU load.