Skip to content

replace deprecated New Buffer() with Buffer.from()#3330

Merged
boneskull merged 1 commit into
mochajs:masterfrom
harrysarson:patch-1
Apr 18, 2018
Merged

replace deprecated New Buffer() with Buffer.from()#3330
boneskull merged 1 commit into
mochajs:masterfrom
harrysarson:patch-1

Conversation

@harrysarson

@harrysarson harrysarson commented Apr 16, 2018

Copy link
Copy Markdown
Contributor

Description of Change

new Buffer() is set to be run time deprecated in node v10 (see nodejs/node#19079 and https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor).

I swapped out the usage of new Buffer() for Buffer.from() in mocha's integration tests.

This should be semver patch.

@outsideris

outsideris commented Apr 18, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Mocha still support node.js v4 and Buffer.from is introduced since v5.10.0.
Supporting node v4 will be drop soon.
This PR should be merged after dropping support node v4, I think.

@outsideris outsideris added the qa label Apr 18, 2018
@harrysarson

harrysarson commented Apr 18, 2018

Copy link
Copy Markdown
Contributor Author

@outsideris Buffer.from is already used in mocha. I found it here:

mocha/test/unit/utils.spec.js

Line 165 in 92beda9

expect(stringify(Buffer.from([0x01]))).to.equal('[\n 1\n]');

The tests pass on node 4 even with this change. It seems the buffer.from was actually added in node v4.5 despite what the docs say:

harry@home:~$ nvm use 4.4
Now using node v4.4.7 (npm v2.15.8)
harry@home:~$ node
> Buffer.from('hi')
TypeError: this is not a typed array.
    at Function.from (native)
    at repl:1:8
    at REPLServer.defaultEval (repl.js:262:27)
    at bound (domain.js:287:14)
    at REPLServer.runBound [as eval] (domain.js:300:12)
    at REPLServer.<anonymous> (repl.js:431:12)
    at emitOne (events.js:82:20)
    at REPLServer.emit (events.js:169:7)
    at REPLServer.Interface._onLine (readline.js:211:10)
    at REPLServer.Interface._line (readline.js:550:8)
> .exit
harry@home:~$ nvm use 4.5
Now using node v4.5.0 (npm v2.15.9)
harry@home:~$ node
> Buffer.from('hi')
<Buffer 68 69>

@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Apr 18, 2018
@boneskull

boneskull commented Apr 18, 2018

Copy link
Copy Markdown
Member

LGTM. Buffer.from() in v4.x only accepts a single parameter, but it's still present in all v4.x versions.

Netlify failure unrelated.

@harrysarson Thanks!

@boneskull boneskull merged commit a6115ac into mochajs:master Apr 18, 2018
@boneskull boneskull added this to the next milestone Apr 18, 2018
@harrysarson harrysarson deleted the patch-1 branch April 18, 2018 17:53
@outsideris

outsideris commented Apr 18, 2018

Copy link
Copy Markdown
Contributor

@harrysarson My bad. I didn't know that node v4 support Buffer.from.

@harrysarson

harrysarson commented Apr 18, 2018

Copy link
Copy Markdown
Contributor Author

No worries, the node docs are definately unclear about this.

@boneskull

boneskull commented Apr 18, 2018

Copy link
Copy Markdown
Member

Yeah, I had to dig into the commit history to figure it out 😝

@ghost ghost mentioned this pull request May 19, 2018
Closed
wopian referenced this pull request in wopian/agc-assembly May 20, 2018
@renovate @wopian
chore(deps): update dependency mocha to ~5.2.0 (#116)
cd35efb 
This Pull Request updates dependency [mocha](https://github.com/mochajs/mocha) from `~5.1.0` to `~5.2.0`



<details>
<summary>Release Notes</summary>

### [`v5.2.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#&#8203;520--2018-05-18)
[Compare Source](mochajs/mocha@v5.1.1...v5.2.0)
#### 🎉 Enhancements

- [#&#8203;3375]: Add support for comments in `mocha.opts` ([@&#8203;plroebuck])
#### 🐛 Fixes

- [#&#8203;3346]: Exit correctly from `before` hooks when using `--bail` ([@&#8203;outsideris])
#### 📖 Documentation

- [#&#8203;3328]: Mocha-flavored [API docs](https://mochajs.org/api/)! ([@&#8203;Munter])
#### 🔩 Other

- [#&#8203;3330]: Use `Buffer.from()` ([@&#8203;harrysarson])
- [#&#8203;3295]: Remove redundant folder ([@&#8203;DavNej])
- [#&#8203;3356](`https://github.com/mochajs/mocha/pull/3356`): Refactoring ([@&#8203;plroebuck])

[#&#8203;3375]: `https://github.com/mochajs/mocha/pull/3375`
[#&#8203;3346]: `https://github.com/mochajs/mocha/pull/3346`
[#&#8203;3328]: `https://github.com/mochajs/mocha/pull/3328`
[#&#8203;3330]: `https://github.com/mochajs/mocha/pull/3330`
[#&#8203;3295]: `https://github.com/mochajs/mocha/pull/3295`

[@&#8203;plroebuck]: https://github.com/plroebuck
[@&#8203;harrysarson]: https://github.com/harrysarson
[@&#8203;outsideris]: https://github.com/outsideris
[@&#8203;Munter]: https://github.com/Munter

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Sep 22, 2018
Closed
Closed
Closed
Merged
Open
Merged
Open
Closed
Closed
Closed
Merged
Closed
Closed
Open
Closed
Closed
This was referenced Oct 4, 2018
Closed
Merged
This was referenced Oct 25, 2018
Merged
Merged
Closed
Closed
This was referenced Nov 1, 2018
Merged
Merged
Merged
This was referenced Nov 9, 2018
Merged
Closed
Closed
Merged
Merged
This was referenced Nov 17, 2018
Merged
Closed
Merged
This was referenced Dec 1, 2018
Closed
Merged
Merged
This was referenced Dec 8, 2018
Merged
Closed
Merged
Closed
This was referenced Dec 23, 2018
Closed
Closed
This was referenced Mar 14, 2020
Closed
Closed
Closed
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes"

Projects

None yet

Milestone

v5.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@harrysarson @outsideris @boneskull