[doc] update chord doc #5701
[doc] update chord doc #5701
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @hjh0119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the clarity and conciseness of the CHORD algorithm documentation. The changes primarily involve simplifying existing explanations and refining descriptions of key components, ensuring that the information is more accessible and to the point for readers.
Highlights
- Documentation Simplification: The introductory description of the CHORD algorithm has been simplified in both Chinese and English documentation, removing specific mentions of 'on-policy' and 'off-policy' contexts and specific algorithms like GRPO/PPO, to make the explanation more concise.
- CHORD-φ Explanation Refinement: The explanation for CHORD-φ (Token-level weighting) has been refined in both language versions, removing details about μ scheduling and fixed μ values, and focusing solely on its core function of dynamically controlling expert token gradient contribution.
- Paper Link Formatting: In the English documentation, the reference to the CHORD paper has been updated from plain text to a direct Markdown link, improving readability and navigation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the CHORD algorithm in both Chinese and English. While the changes aim for simplification, they remove important details about the algorithm's mechanics, such as the distinction between on-policy and off-policy learning and key characteristics of the CHORD-φ variant. My review suggests restoring this information to ensure the documentation remains accurate and clear for users.
No description provided.