feat: improve environment variable handling and CORS configuration fo… #803

inoribea · 2025-12-16T08:57:43Z

Summary

This PR improves environment variable handling and CORS configuration for Vercel deployment, fixing issues with provider health checks and WebSocket connections.

Details

Adds logic to skip provider health checks in browser environments to avoid CORS errors
Implements smart WebSocket URL detection with automatic protocol switching
Updates CORS configuration to support font loading and API requests
Improves environment variable validation and fallback behavior
Adds configuration options for different deployment scenarios

Testing

Verify that provider health checks are properly skipped in browser
Test WebSocket connections work in different environments
Confirm CORS errors are resolved for font loading
Ensure environment variable fallbacks work correctly
Verify API requests work without CORS issues

…r Vercel deployment

gemini-code-assist · 2025-12-16T08:58:01Z

Summary of Changes

Hello @inoribea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the application's resilience and deployment flexibility by refining environment variable handling and addressing critical CORS-related issues. It introduces intelligent mechanisms for WebSocket URL determination and conditional skipping of provider health checks, ensuring smoother operation across different deployment environments, especially Vercel. Additionally, it standardizes code quality through a new ESLint configuration.

Highlights

Environment Variable Handling: Enhanced the way environment variables are processed, particularly for WebSocket URLs and provider health checks, allowing for more flexible and robust configuration across different deployment scenarios.
CORS Configuration Improvements: Updated CORS settings to resolve issues with font loading and API requests, specifically addressing challenges encountered in Vercel deployments.
Conditional Provider Health Checks: Implemented logic to conditionally skip provider health checks in browser environments, preventing unnecessary network requests and potential CORS errors.
Smart WebSocket URL Detection: Introduced intelligent detection for WebSocket URLs, including automatic protocol switching (ws/wss) and the ability to disable connections based on environment variables or deployment context.
New ESLint Configuration: Added a new ESLint configuration file to enforce coding standards, improve code quality, and ensure consistent formatting across the codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces several well-implemented improvements for environment-specific configurations, particularly for Vercel deployments. Key changes include dynamic WebSocket URL detection to prevent connection errors in production browser environments, a mechanism to skip provider health checks to mitigate CORS issues, and updates to font configurations to resolve loading problems. A new ESLint configuration is also added to enforce code style. My feedback focuses on minor code simplifications and ensuring consistency with the newly introduced linting rules. Overall, the changes are solid and effectively address the stated objectives.

gemini-code-assist · 2025-12-16T09:06:29Z

packages/server-sdk/src/client.ts


  private _connect(): Promise<void> {
+    // If URL is empty, WebSocket is disabled - silently skip connection
+    if (!this.opts.url || this.opts.url === '') {


For conciseness, you can simplify this check. In TypeScript/JavaScript, an empty string ('') is a falsy value, so !this.opts.url will correctly evaluate to true for null, undefined, and ''. This makes the explicit check for an empty string redundant.

Suggested change

if (!this.opts.url || this.opts.url === '') {

if (!this.opts.url) {

gemini-code-assist · 2025-12-16T09:06:29Z

packages/server-sdk/src/client.ts


-        this.opts.onError?.(event)
+        // Only log error if not intentionally disabled
+        if (this.opts.url && this.opts.url !== '') {


Similar to my other comment, you can simplify this condition. The check this.opts.url && this.opts.url !== '' can be shortened to just this.opts.url, as an empty string is falsy.

Suggested change

if (this.opts.url && this.opts.url !== '') {

if (this.opts.url) {

gemini-code-assist · 2025-12-16T09:06:29Z

packages/server-sdk/src/client.ts

        }
-        if (this.opts.autoReconnect && !this.shouldClose) {
+        // Don't auto-reconnect if WebSocket is disabled
+        if (this.opts.autoReconnect && !this.shouldClose && this.opts.url && this.opts.url !== '') {


This condition can also be simplified. The check for this.opts.url && this.opts.url !== '' is redundant. A simple truthy check with this.opts.url is sufficient to cover cases where the URL is undefined, null, or an empty string.

Suggested change

if (this.opts.autoReconnect && !this.shouldClose && this.opts.url && this.opts.url !== '') {

if (this.opts.autoReconnect && !this.shouldClose && this.opts.url) {

gemini-code-assist · 2025-12-16T09:06:29Z

packages/stage-ui/src/stores/providers/openai-compatible-builder.ts

+      const skipHealthChecks = envSkipHealthCheck !== undefined
+        ? envSkipHealthCheck === 'true' || envSkipHealthCheck === true
+        : defaultSkipInBrowser


This logic for determining skipHealthChecks can be made more concise. Using String(envSkipHealthCheck) === 'true' handles both boolean true and string 'true' values correctly, while still falling back to defaultSkipInBrowser when envSkipHealthCheck is undefined.

Suggested change

const skipHealthChecks = envSkipHealthCheck !== undefined

? envSkipHealthCheck === 'true' || envSkipHealthCheck === true

: defaultSkipInBrowser

const skipHealthChecks = envSkipHealthCheck !== undefined

? String(envSkipHealthCheck) === 'true'

: defaultSkipInBrowser

gemini-code-assist · 2025-12-16T09:06:29Z

packages/stage-ui/src/stores/providers/openai-compatible-builder.ts

+
+      if (skipHealthChecks) {
+        // eslint-disable-next-line no-console
+        console.log('[Provider] Skipping health checks (SKIP_PROVIDER_HEALTH_CHECK=true or browser environment)')


The new ESLint configuration in eslint.config.ts disallows console.log. To adhere to the new linting rules, please use console.info instead, which is permitted.

Suggested change

console.log('[Provider] Skipping health checks (SKIP_PROVIDER_HEALTH_CHECK=true or browser environment)')

console.info('[Provider] Skipping health checks (SKIP_PROVIDER_HEALTH_CHECK=true or browser environment)')

feat: improve environment variable handling and CORS configuration fo…

2d29879

…r Vercel deployment

gemini-code-assist bot reviewed Dec 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: improve environment variable handling and CORS configuration fo… #803

feat: improve environment variable handling and CORS configuration fo… #803

inoribea commented Dec 16, 2025

Uh oh!

gemini-code-assist bot commented Dec 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Dec 16, 2025

Uh oh!

gemini-code-assist bot Dec 16, 2025

Uh oh!

gemini-code-assist bot Dec 16, 2025

Uh oh!

gemini-code-assist bot Dec 16, 2025

Uh oh!

gemini-code-assist bot Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	if (!this.opts.url \|\| this.opts.url === '') {
	if (!this.opts.url) {

	if (this.opts.url && this.opts.url !== '') {
	if (this.opts.url) {

	if (this.opts.autoReconnect && !this.shouldClose && this.opts.url && this.opts.url !== '') {
	if (this.opts.autoReconnect && !this.shouldClose && this.opts.url) {

	console.log('[Provider] Skipping health checks (SKIP_PROVIDER_HEALTH_CHECK=true or browser environment)')
	console.info('[Provider] Skipping health checks (SKIP_PROVIDER_HEALTH_CHECK=true or browser environment)')

Uh oh!

feat: improve environment variable handling and CORS configuration fo… #803

Are you sure you want to change the base?

feat: improve environment variable handling and CORS configuration fo… #803

Conversation

inoribea commented Dec 16, 2025

Summary

Details

Testing

Uh oh!

gemini-code-assist bot commented Dec 16, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant