Skip to content

Replace deprecated CheckInherents with an equivalent ConsensusHook #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RomarQ merged 34 commits into from
Oct 9, 2025
Merged

Replace deprecated CheckInherents with an equivalent ConsensusHook #3397

RomarQ merged 34 commits into from
Oct 9, 2025

Conversation

@RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Aug 18, 2025 •
edited
Loading

What does it do?

Replaces deprecated CheckInherents with an equivalent ConsensusHook. (cumulus changes: paritytech/cumulus#2300)

Discussion in Polkadot-sdk: paritytech/polkadot-sdk#2841

CheckInherents was removed in paritytech/polkadot-sdk#9732

What important points should reviewers know?

@RomarQ RomarQ self-assigned this Aug 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rq/remove-deprecated-check-inherents

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomarQ RomarQ changed the title Rq/remove deprecated check inherents Replace deprecated CheckInherents with an equivalent ConsensusHook Aug 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 1992 KB (no changes) ✅

Moonbeam runtime: 2096 KB (-8 KB) ✅

Moonriver runtime: 2100 KB (-4 KB) ✅

Compared to latest release (runtime-3900)

Moonbase runtime: 1992 KB (-368 KB compared to latest release) ✅

Moonbeam runtime: 2096 KB (-384 KB compared to latest release) ✅

Moonriver runtime: 2100 KB (-380 KB compared to latest release) ✅

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025 •
edited
Loading

Coverage Report

@@                           Coverage Diff                            @@
##           master   rq/remove-deprecated-check-inherents      +/-   ##
========================================================================
+ Coverage   74.46%                                 74.51%   +0.05%     
- Files         397                                    396       -1     
- Lines       96013                                  95981      -32     
========================================================================
+ Hits        71493                                  71519      +26     
- Misses      24520                                  24462      -58
Files Changed Coverage
/node/service/src/lib.rs 55.49% (+0.37%) 🔼
/node/service/src/rpc.rs 85.06% (+1.73%) 🔼
/runtime/moonbase/src/lib.rs 57.20% (+1.69%) 🔼
/runtime/moonbase/tests/common/mod.rs 94.52% (-0.06%) 🔽
/runtime/moonbeam/src/lib.rs 50.59% (+1.33%) 🔼
/runtime/moonbeam/tests/common/mod.rs 92.94% (-0.07%) 🔽
/runtime/moonriver/src/lib.rs 50.51% (+1.34%) 🔼
/runtime/moonriver/tests/common/mod.rs 94.19% (-0.05%) 🔽

Coverage generated Thu Oct 9 12:20:31 UTC 2025

@RomarQ RomarQ added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Sep 19, 2025
@RomarQ RomarQ added the not-breaking Does not need to be mentioned in breaking changes label Sep 22, 2025
@RomarQ RomarQ marked this pull request as ready for review September 23, 2025 18:37
@RomarQ RomarQ added the D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Sep 23, 2025
manuelmauro
manuelmauro previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@manuelmauro manuelmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

manuelmauro
manuelmauro previously approved these changes Oct 9, 2025
View reviewed changes
@RomarQ
Copy link
Contributor Author

RomarQ commented Oct 9, 2025

This chopsticks PR broke our chopsticks tests for the changes included in this PR. Looking into it

@RomarQ RomarQ merged commit ae4f29a into master Oct 9, 2025
40 checks passed
@RomarQ RomarQ deleted the rq/remove-deprecated-check-inherents branch October 9, 2025 12:45
@RomarQ RomarQ mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelmauro manuelmauro manuelmauro approved these changes

@TarekkMA TarekkMA Awaiting requested review from TarekkMA

@librelois librelois Awaiting requested review from librelois

Assignees

@RomarQ RomarQ

Labels

B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomarQ @manuelmauro