Remove bridge features from moonbase runtime #3437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2676 KB (no changes) ✅ Moonbeam runtime: 2848 KB (no changes) ✅ Moonriver runtime: 2844 KB (no changes) ✅ Compared to latest release (runtime-3900)Moonbase runtime: 2676 KB (+316 KB compared to latest release) Moonbeam runtime: 2848 KB (+368 KB compared to latest release) Moonriver runtime: 2844 KB (+364 KB compared to latest release) |
Contributor
Coverage Report@@ Coverage Diff @@
## master rq/remove-bridge-features-from-moonbase-runtimes +/- ##
====================================================================================
+ Coverage 74.09% 74.10% +0.01%
- Files 406 404 -2
- Lines 98579 98522 -57
====================================================================================
- Hits 73037 73005 -32
- Misses 25542 25517 -25
|
manuelmauro
approved these changes
Sep 5, 2025
Contributor
manuelmauro
left a comment
There was a problem hiding this comment.
LGTM. Do we need any migration for this?
Contributor
Author
I would say that we don't need a migration, those pallets were never included in Alphanet, only on betanet and stagenet. |
librelois
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Reverts most of the changes included in Bridge setup (Stagenet <-> Betanet)
What important points should reviewers know?
Since we now have a proper testnet for testing the bridge between
MoonbeamandMoonriver, there is no longer the need to have the bridging functionality in the moonbase-runtime.