Skip to content

Update storage benchmarks #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manuelmauro merged 15 commits into from
Sep 26, 2025
Merged

Update storage benchmarks #3459

manuelmauro merged 15 commits into from
Sep 26, 2025

Conversation

@manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Sep 23, 2025 •
edited
Loading

⚠️ Breaking Changes ⚠️

  • Increased DB read/write weights.

What does it do?

Updates storage benchmarks by running them on 50M keys from current Moonbeam state.

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch manuel/update-storage-benchmarks-20250923

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@manuelmauro manuelmauro self-assigned this Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Moonbase Weight Difference Report

File Extrinsic Old New Change Percent

Moonriver Weight Difference Report

File Extrinsic Old New Change Percent

Moonbeam Weight Difference Report

File Extrinsic Old New Change Percent

@manuelmauro manuelmauro added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes and removed breaking Needs to be mentioned in breaking changes B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes labels Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2608 KB (-4 KB) ✅

Moonbeam runtime: 2776 KB (no changes) ✅

Moonriver runtime: 2768 KB (no changes) ✅

Compared to latest release (runtime-3900)

Moonbase runtime: 2608 KB (+248 KB compared to latest release) ⚠️

Moonbeam runtime: 2776 KB (+296 KB compared to latest release) ⚠️

Moonriver runtime: 2768 KB (+288 KB compared to latest release) ⚠️

@manuelmauro manuelmauro added the breaking Needs to be mentioned in breaking changes label Sep 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2025 •
edited
Loading

Coverage Report

@@                              Coverage Diff                              @@
##           master   manuel/update-storage-benchmarks-20250923      +/-   ##
=============================================================================
+ Coverage   74.51%                                      74.55%   +0.04%     
  Files         392                                         392              
+ Lines       95801                                       95921     +120     
=============================================================================
+ Hits        71385                                       71505     +120     
  Misses      24416                                       24416
Files Changed Coverage
/runtime/moonbase/tests/integration_test.rs 99.28% (+0.01%) 🔼
/runtime/moonbeam/tests/integration_test.rs 99.36% (+0.01%) 🔼
/runtime/moonriver/tests/integration_test.rs 99.35% (+0.01%) 🔼

Coverage generated Thu Sep 25 14:46:30 UTC 2025

RomarQ
RomarQ reviewed Sep 25, 2025
View reviewed changes
RomarQ
RomarQ reviewed Sep 25, 2025
View reviewed changes
RomarQ
RomarQ reviewed Sep 25, 2025
View reviewed changes
RomarQ
RomarQ reviewed Sep 25, 2025
View reviewed changes
RomarQ
RomarQ reviewed Sep 25, 2025
View reviewed changes
RomarQ
RomarQ reviewed Sep 25, 2025
View reviewed changes
@manuelmauro manuelmauro marked this pull request as ready for review September 25, 2025 13:34
@manuelmauro
Copy link
Contributor Author

manuelmauro commented Sep 25, 2025

Removing here a failing test that will be independently removed in #3440

@manuelmauro manuelmauro requested a review from RomarQ September 25, 2025 16:01
@manuelmauro manuelmauro merged commit d105244 into master Sep 26, 2025
104 of 107 checks passed
@manuelmauro manuelmauro deleted the manuel/update-storage-benchmarks-20250923 branch September 26, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomarQ RomarQ RomarQ approved these changes

Assignees

@manuelmauro manuelmauro

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuelmauro @RomarQ