Skip to content

Fix dryRunXcm Api #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RomarQ merged 12 commits into from
Sep 26, 2025
Merged

Fix dryRunXcm Api #3461

RomarQ merged 12 commits into from
Sep 26, 2025

Conversation

@TarekkMA
Copy link
Contributor

@TarekkMA TarekkMA commented Sep 25, 2025

use Config::XcmExecutor inside dry_run_xcm, so we have the correct environmental setup for erc20 tokens

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tarekkma/fix-dry-run-xcm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TarekkMA TarekkMA linked an issue Sep 25, 2025 that may be closed by this pull request
Moonbeam gives Failed to transact asset in DryRun for Wormhole assets, but transaction works just fine #3390
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2608 KB (no changes) ✅

Moonbeam runtime: 2768 KB (-8 KB) ✅

Moonriver runtime: 2764 KB (-4 KB) ✅

Compared to latest release (runtime-3900)

Moonbase runtime: 2608 KB (+248 KB compared to latest release) ⚠️

Moonbeam runtime: 2768 KB (+288 KB compared to latest release) ⚠️

Moonriver runtime: 2764 KB (+284 KB compared to latest release) ⚠️

@TarekkMA TarekkMA added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

Coverage Report

@@                     Coverage Diff                     @@
##           master   tarekkma/fix-dry-run-xcm     +/-   ##
===========================================================
  Coverage   74.55%                     74.55%   0.00%     
  Files         392                        392             
- Lines       95921                      95917      -4     
===========================================================
  Hits        71505                      71505             
- Misses      24416                      24412      -4
Files Changed Coverage
/runtime/common/src/apis.rs 85.56% (+0.30%) 🔼

Coverage generated Fri Sep 26 13:09:12 UTC 2025

RomarQ
RomarQ reviewed Sep 26, 2025
View reviewed changes
RomarQ
RomarQ reviewed Sep 26, 2025
View reviewed changes
@RomarQ RomarQ merged commit 8263a7e into master Sep 26, 2025
71 of 73 checks passed
@RomarQ RomarQ deleted the tarekkma/fix-dry-run-xcm branch September 26, 2025 13:25
manuelmauro added a commit that referenced this pull request Oct 3, 2025
@manuelmauro @RomarQ
Fix dryRunXcm Api (#3461)
7988dd0 
* fix xcm dry-run

* update Cargo.lock

* fix test

---------

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
manuelmauro added a commit that referenced this pull request Oct 3, 2025
@manuelmauro @RomarQ @stiiifff
Apply cherrypick on perm branch (#3480)
61f6e9b 
* chore: ⬆️ update polkadot-sdk

* Fix dryRunXcm Api (#3461)

* fix xcm dry-run

* update Cargo.lock

* fix test

---------

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>

* chore: ⬆️ upgrade moonwall

---------

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
Co-authored-by: Steve Degosserie <723552+stiiifff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomarQ RomarQ RomarQ approved these changes

Assignees

No one assigned

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Moonbeam gives Failed to transact asset in DryRun for Wormhole assets, but transaction works just fine

3 participants

@TarekkMA @RomarQ