Trex modules#247
Open
mooch443 wants to merge 113 commits into
Open
Conversation
Add LIBRARY_BIN to PATH before CMake configuration to ensure git is accessible during FetchContent patch operations. This fixes the 'git is not recognized' error on Windows builds. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Enhanced the PATH setup to check both BUILD_PREFIX and LIBRARY_BIN locations, with better diagnostics and error messaging. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
- Removed truncated PATH display that could be misleading - Changed to exit with error code if git not found (fail fast) - Improved error message clarity Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Silent check first, then display git path and version only on success. Cleaner diagnostic output. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Changed from ${GITHUB_REF##*/} to ${GITHUB_REF#refs/heads/} in all workflow files to correctly handle branch names containing slashes (e.g., copilot/fix-git-command-error).
Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Replace forward slashes with underscores in branch names before using them in conda meta.yaml to avoid CondaBuildUserError with invalid characters. Branch names like 'copilot/fix-git-command-error' now become 'copilot_fix-git-command-error' in build strings. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Conda build strings cannot contain hyphens either. Added second sanitization step to replace hyphens with underscores after slash replacement. Branch 'copilot/fix-git-command-error' now becomes 'copilot_fix_git_command_error'. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Use original branch name for git checkout (git_tag) and sanitized name for build string (git_tag_sanitized). This fixes the issue where conda tried to checkout a sanitized branch name that doesn't exist. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
The git checking code added in bld.bat was causing the build to fail with exit code 255. Since git is already available as a conda build dependency, the explicit checking is not needed. Removing it to fix the Windows build. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Git is needed for CMake's FetchContent PATCH_COMMAND but was removed to fix exit code 255. This re-adds the PATH setup in a simpler form without the error checking that was causing the issue. Now git will be available for the dialogs patch step. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
Added DEBUG echo statements around PATH modification to understand where the script is failing with exit code 255. Co-authored-by: mooch443 <2864719+mooch443@users.noreply.github.com>
… custom button options. * VisualIdentDialog: Added a controller for managing video identification tasks and training data generation. * Build: Enabled test builds for the application.
…tations. * Cleared deprecated object detection and segmentation logic.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
added 11 commits
March 20, 2026 23:23
* Deleted unused PSD logo file from the tracker.
…and sources from the tracker configuration. * Updated subproject commit reference in commons.
…lined configuration handling. * Terminal: Updated Python wrapper inclusion to reflect new directory structure. * Build Scripts: Added macOS and Ubuntu initialization scripts for environment setup and dependency installation.
* Changed C++ standards to C23 and C++23 in configuration files. * Added support for semantic modules in CMake configuration and tests. * Implemented new module interfaces for core, data, detect, tracking, ml, and ui components. * Enabled module building in the macOS build script.
* Modified video length handling in Segmenter to account for base video source length. * Enhanced acceptance criteria in YOLO processing to use pixel count instead of blob.
* Modified CMake configuration to conditionally link libraries based on shared library settings. * Removed unnecessary dependencies from various components.
…line options. * pvinfo added functionality to handle OpenCV FFMPEG and OpenCL support checks. * pvinfo_merge implemented merging logic for multiple video files with configurable background handling.
…s for Windows. * Updated target compile definitions for shared libraries to handle export visibility based on platform. * Updated submodule reference in commons to the latest commit.
…eduling. * Enhanced Python availability checks with export declarations.
* Modified CMakeLists to link commons library conditionally based on module settings. * Enhanced AGENTS.md with instructions for shared-library split testing with modules enabled.
added 30 commits
April 1, 2026 16:38
* Fixed API endpoint response format to ensure consistent data structure. * Enhanced CLI command options for better user experience and functionality.
…me evaluation. * Modified test cases to ensure proper parsing and validation of prompt data structures. * Enhanced JSON serialization methods for various data types to streamline data handling.
* Updated LiveSegmentation to manage frame requests more efficiently and discard irrelevant frames. * Implemented normalization for prompt payloads to ensure consistent point and box coordinates across different image sizes.
…d maintain timeline state. * Modified prompt handling to accommodate video-specific prompts and caching mechanisms. * Enhanced prediction process to handle frame-by-frame inference and replay logic for improved performance.
* Implemented set_iou_threshold API to update IoU threshold for predictions. * Enhanced session management to utilize detect_iou_threshold from requests.
…t action. * Adjusted mask resizing logic to improve cropping accuracy in result processing. * Simplified bounding box representation in output format.
* main.cpp ensured data location is created before global settings. * trex_sam3_interface.py implemented runtime checkpoints for session state management and restored state handling.
…tion. * Modified layout configuration to include a horizontal layout with buttons for frame reset and settings. * Enhanced Python runtime configuration logging for better debugging.
…t, enabling runtime adjustments based on confidence thresholds. * Implemented runtime state management for the predictor, allowing for snapshot and restoration of the session state. * Updated configuration settings to include confidence threshold adjustments, affecting detection behavior during runtime.
…tation headers. * Included SAM3InteractiveSession source file in Python implementation sources.
* Updated build configuration to prevent undefined symbol errors on Apple platforms. * Enhanced output file handling in interactive segmentation.
…updates. * Added logging for frame index and position during file operations.
* Updated IoU threshold handling to allow optional overrides in detection settings. * Adjusted inference method to support optional IoU threshold for improved detection flexibility.
…me-indexed prompts. * Modified session handling to prevent committing frames with mismatched session generations. * Adjusted runtime preparation to include session generation in processed frames.
… dependencies. * Removed broad conda update in favor of specific package installations for better control.
* Removed unused box type from prompt type enumeration. * Updated layout to display annotations in the interactive segmentation prototype.
* Improved logging to include the index when caching frames.
* Integrated TileBuffers creation in main application flow. * Updated Python integration to support TileBuffers configuration.
…stance access. * Added TileBuffers instance management in LiveSegmentation activation process.
… and tiling tests. * Implemented image resizing logic for SAM3 processing to handle offsets and scales. * Enhanced Python interface with functions for estimating original image shape and restoring masks.
…roved memory management. * Adjusted library type settings for UI components on Windows to prevent linker issues. * Modified Python environment setup to ensure correct PATH variable configuration.
…g and replay features. * Modified runtime behavior to focus on processing frames directly without caching intermediate states. * Adjusted logging to provide clearer diagnostics for session lifecycle events.
…ng shutdown. * Cleared remaining tile buffer images in Python wrapper and detection deinitialization. * Updated LiveSegmentation to clear tile buffer images upon deactivation.
…bling visual feedback during processing. * API Updated prompt handling to support multiple geometric prompts, allowing simultaneous object detection. * Build Updated package dependencies to support the latest versions of core libraries and added new dependencies for enhanced functionality.
* Normalized prompt payloads for consistent handling of input dimensions. * Implemented prompt state management for improved prompt resolution in image processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.