Skip to content

[docs] Error in quizaccess#rulephp #1434

Description

@mkpelletier

What is the URL of the page?

https://moodledev.io/docs/5.0/apis/plugintypes/quizaccess#rulephp

What is the issue with this page?

The url in this line goes to a non-existent page:
"Please refer to the inline phpdocs of the mod_quiz::rule_overridable interface for detailed descriptions of the functions and meaning."

Moreover, the class "rule_overridable" does not appear to be implemented as given in the following example.

Are you able to provide a patch for this?

No (Default)

Activity

  1. added
    bugSomething isn't working
    documentationImprovements or additions to documentation
    help wantedExtra attention is needed
    on Sep 18, 2025
  2. timhunt commented on Sep 18, 2025

    @timhunt
    Collaborator

    Ah! this is cause by the change that moved code to the /public folder.

  3. timhunt commented on Sep 18, 2025

    @timhunt
    Collaborator

    Needs changes in a few files, so I can't do it now using the github UI.

    #1435 is part of the required chagnes, but more work needed.

  4. timhunt commented on Sep 18, 2025

    @timhunt
    Collaborator

    I probalby won't have time. Helpful if someone else can finish fixing this.

  5. mkpelletier commented on Sep 19, 2025

    @mkpelletier
    Author

    Thanks, Tim.

    In addition to the path change, the target file doesn't exist either. For example, the earlier links work if you change the path:
    https://github.com/moodle/moodle/blob/main/public/mod/quiz/classes/local/access_rule_base.php < This exists

    But at the bottom of the documentation, mutatis-mutundis:
    https://github.com/moodle/moodle/blob/main/public/mod/quiz/classes/local/rule_overridable.php < this does NOT exist

    The net effect is that if I try to implement rule_overridable as described, it doesn't exist anywhere in core. How do I override an access rule if this is the case?

  6. timhunt commented on Oct 1, 2025

    @timhunt
    Collaborator

    This is now being dealt with in pull 1441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentationhelp wantedExtra attention is neededneeds-triage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions