Skip to content

Add debounce to push button #401

Open

Description

@lwYeo

Missing feature

Debouncing does not seem to be present when pressing down the button.
Maybe adding around 100ms would be nice.

Justification

Sometimes the button "double-clicked" by itself, occurrence seem to be 1 in 10 or less (at least on my device).
Although it does not seem much, but it is rather annoying when it happens, especially when entering the last digit pin, causing unwanted "invalid pin" incidents.

Activity

  1. limpkin commented on May 7, 2023

    @limpkin
    Contributor
  2. lwYeo commented on May 7, 2023

    @lwYeo
    Author

    there's actually already a debounce: https://github.com/mooltipass/minible/blob/master/source_code/main_mcu/src/INPUTS/inputs.c#L275, set to 100ms

    Nice.
    Since different unit may have different tolerances, would it be better if we can customise it?
    If not can we increase to maybe 150ms-200ms, to reduce this issue further?

  3. limpkin commented on May 7, 2023

    @limpkin
    Contributor

    that's indeed a great idea!

  4. My1 commented on May 8, 2023

    @My1
    Contributor

    might this be the same reason why i sometimes dont get a wheel move when moving quickly through the numbers when trying to enter my pin?

  5. limpkin commented on May 9, 2023

    @limpkin
    Contributor

    not exactly no

  6. CGuy-1 commented on May 29, 2023

    @CGuy-1

    I have this issue with my early unit, it seems the scroll wheel starts to do this after lots of use. This will just get worse and worse until the wheel stops working. I've replaced this unit with a new one that I think has a better scroll wheel installed. The new one doesn't exhibit any issues but it's only been 6 months.

  7. limpkin commented on May 30, 2023

    @limpkin
    Contributor

    Hello, are you saying you aren't able to click anymore?

  8. seviu commented on May 31, 2023

    @seviu

    I got same problem

  9. limpkin commented on May 31, 2023

    @limpkin
    Contributor

    @seviu : can you expand on your symptoms? :)

  10. CGuy-1 commented on May 31, 2023

    @CGuy-1

    @limpkin I can click but it will sometimes scroll at the same time. Just touching the scroll wheel lightly will sometimes make it scroll very quickly in one direction or the other. If I push down on the scroll wheel while clicking it works much better. This leads me to think the issue is hardware, the scroll wheel has failed and the contacts and/or wheel are lose. I have a very early unit and I use it all the time so perhaps the scroll wheel part isn't robust enough.

  11. limpkin commented on Aug 30, 2023

    @limpkin
    Contributor

    @CGuy-1 is this still happening? I could offer a device swap...

  12. CGuy-1 commented on Sep 6, 2023

    @CGuy-1

    Yes, I suspect the scroll wheel contacts are broken or worn out. This is an early unit and I use it all the time so it may just need a new scroll wheel component. The battery doesn't hold a charge any more (and yes I've run the refresh several times), is it possible to replace it?

  13. limpkin commented on Sep 6, 2023

    @limpkin
    Contributor

    send me a quick email, we'll work something out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions