Extend Duration documentation to document different behaviour when created out of factory methods #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include reference to different behaviour for Durations created out of factory methods
The committers listed above are authorized under a signed CLA. |
diesieben07
requested changes
May 15, 2024
Collaborator
diesieben07
left a comment
There was a problem hiding this comment.
Unfortunately the documentation you have added is factually not correct.
I also don't think we should be copy pasting the same text at all the accessors.
Comment on lines
+868
to
+869
| * Note: Durations created out of Duration.from* (e.g. fromObject) factories will always yield 0. | ||
| * This will give you the correct difference in years, if the Duration was created out of a diff operation. |
Collaborator
There was a problem hiding this comment.
This is factually incorrect. Duration.fromObject({ years: 2 }).years is 2, not 0.
I am not sure what you're referring to by "correct difference in years" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1626