moment.min returns different results depending on the order

If I try to get the min of two moments, one of which is invalid, then the result I get depends on the order in which I specify the moments:

moment.min(moment(""), moment()).toDate()
// Invalid Date
moment.min(moment(), moment("")).toDate()
// Wed May 06 2015 14:52:20 GMT-0500 (CDT)

I'm not sure what the expected behavior should be, but what I expected is something like this:

function getMin() {
  var dates = Array.prototype.slice.call(arguments);
  dates = dates.filter(function (a) {return a.isValid();});
  // etc.
}

Consider:

Therefore, I would expect any moment compared to an invalid moment to return the invalid moment.

That sounds right to me, not necessarily what I would expect, but certainly logical and predictable.

Well, PRs is welcome :)

Ensure moment.isAfter and moment.isBefore match js math operations

Add tests and fix for inconsistent moment.min and moment.max behavior.

Close in favor of #2438

Note that you still have to filter out invalid moments yourself, or you'll get some invalid result (one of the args).

Ensure moment.isAfter and moment.isBefore match js math operations

Add tests and fix for inconsistent moment.min and moment.max behavior.

Navigation Menu