Fix various bugs causing hangs on Xunit #1654
Conversation
|
nice work @alexanderkyte! I'm really looking forward to being able to run xunit 2.0 in Mono |
|
+1 to what @adamralph said hah. |
|
build |
|
I think it's safe to say that all the tests for this are passing, as the broken one looks like a jenkins bug I've been seeing on other bug builds. Hold off on merging for a bit, I'm putting together a test for this specific crasher. It's pretty hard to extract from xunit, but at least it's not a race condition. It's pretty deterministic. |
ac65914 to
cdc178a
Compare
35027e3 to
8407588
Compare
|
build |
|
I'm seeing the error that has been haunting us on public jenkins arm for a while. |
This is a better fix for the problem of what type to give an object when the actual type can't be loaded in the current domain.
300f0e7 to
7f898e1
Compare
When using a TransparentProxy, we run into the problem that the cache is shared between all marshalbyrefobjects. The fix here is to not update the cache when using a TransparentProxy, so that the correct slow path is used.
7f898e1 to
b52f3de
Compare
|
@kumpera I've updated the PR to bring the fixes to castclass, and extracted the caching behavior into a function. The indents look a bit absurd in a diff, but when in an editor where a tab is 8 spaces, as per the style guide, it's lined up. |
Fix various bugs causing hangs on Xunit
Fix various bugs causing hangs on Xunit Commit migrated from mono/mono@738acc7
No description provided.