Add default and options to MongoClient.get_default_database()
#693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c18434a to
fc9af4c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #693 +/- ##
========================================
Coverage 95.37% 95.37%
========================================
Files 19 19
Lines 3612 3614 +2
========================================
+ Hits 3445 3447 +2
Misses 167 167
Continue to review full report at Codecov.
|
pcorpet
approved these changes
Jan 22, 2021
tests/test__mongomock.py
Outdated
| c.get_default_database() | ||
|
|
||
| def test__getting_default_database_with_default_parameter(self): | ||
| def client(uri): |
Member
There was a problem hiding this comment.
No need to create that here as you ony create one client.
Same below
Contributor
Author
There was a problem hiding this comment.
You're right. Sorry for the cargo-cult.
I've dropped them and rebased the PR.
0810ad6 to
16377a2
Compare
Contributor
Author
|
I don't know what to make of the one failing test. I don't think it's related to the changes in this PR. |
Add the `default=` parameter to `MongoClient.get_default_database()` to equalize behavior with `pymongo`. Forward remaining keyword arguments from `MongoClient.get_default_database()` to `MongoClient.get_database()`.
16377a2 to
64f8f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
default=parameter toMongoClient.get_default_database()to equalize behavior withpymongo.Forward remaining keyword arguments from
MongoClient.get_default_database()toMongoClient.get_database().