Optional file storage for data persistence#881
Open
ikondov wants to merge 7 commits into
Open
Conversation
4 tasks
Author
|
@pcorpet: Addressing your suggestion in #350, the Database API is not modified at all. Only the storage classes are extended with serialization methods and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persistence topic has been already addressed in issues #350 and #406. We have another use case where the tests of the command line interface require saving the database and making it available across several processes. Therefore, some temporary file storage is necessary.
This can be accomplished by a small extension of the classes in
store.py. The file store is not intended to keep database state instantly on disk. Rather the database is eventually dumped to a file just before theServerStoreobject is destroyed.It is a work in progress: TODO: a transparent method to pass the option to use a database file with a database file path. This can be accomplished e.g. by using an environment variable.The persistence is activated either by setting the environment variable MONGOMOCK_SERVERSTORE_FILE to a non-empty JSON file (initialized with '{}'):
export MONGOMOCK_SERVERSTORE_FILE=/full/path/to/mongomock_file.jsonor create a custom
ServerStoreobject by passing thefilenamekeyword argument: