Fix #1056: ensure boundary in TaskCreate if LCP enabled#1063
Merged
Conversation
The optimization bypassing the async boundary can break Local isolation.
Avasil
reviewed
Oct 30, 2019
| if (shouldPop) ctx.connection.pop() | ||
| // Optimization — if the callback was called on the same thread | ||
| // where it was created, then we are not going to fork | ||
| // This is not safe to do when localContextPropagation enabled |
Collaborator
Author
There was a problem hiding this comment.
Because this extends a TrampolinedRunnable, and TracingScheduler extends BatchingScheduler, doing execute bypasses the TracingRunnable creation and context isolation that it has.
Without that isolation, the continuation of that async/asyncF/etc. node therefore will have the context from whoever called the cb, not from where the async was actually created.
That only happened in case cb was called synchronously, but it does happen deep in ConcurrentChannel impl in certain concurrent usage patterns with fast producer and slow-ish consumer.
Avasil
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optimization bypassing the async boundary can break Local isolation.