Add withFilter to Iterant#1132
Merged
Merged
Conversation
Avasil
approved these changes
Feb 19, 2020
Collaborator
Avasil
left a comment
There was a problem hiding this comment.
Thank you @mantasindrasius
alexandru
reviewed
Feb 19, 2020
| /** Filters the iterant by the given predicate function, returning | ||
| * only those elements that match. | ||
| * | ||
| * Example: {{{ |
Member
There was a problem hiding this comment.
In this ScalaDoc we could simply mention that it's an alias of filter, which is better because people need to know that the main function is.
If we mention anything in this documentation, we should mention the reason for its existence (i.e. to make it compatible with for-comprehensions).
Collaborator
There was a problem hiding this comment.
In Observable PR: #1129
I did
/** Alias to [[filter]] to support syntax in for comprehension, i.e.
*
* {{{
* case class Person(age: Long)
*
* val peopleObservable: Observable[Person] =
* Observable.range(1, 100).map(Person.apply)
*
* for {
* adult <- peopleObservable if adult.age >= 18
* } yield adult
* }}}
*/
Collaborator
There was a problem hiding this comment.
Okay, I'll just update that PR since I have already merged this one
mdedetrich
pushed a commit
to mdedetrich/monix
that referenced
this pull request
Mar 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cousin of #1129