Only include JCTools in executionShadedJCTools#1514
Merged
Conversation
Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
alexandru
pushed a commit
that referenced
this pull request
May 9, 2022
Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
alexandru
pushed a commit
that referenced
this pull request
May 9, 2022
Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
Here's the content of the currently published jar
All the
scala/collection/compatstuff shouldn't probably be there and it can cause conflicts when running assembly in an app which brings in a different version ofscala-collection-compat(e.g.scala-collection-compat.propertieswill conflict).This bug was originally reported on the Scala Discord (see https://discordapp.com/channels/632150470000902164/635669047588945930/907577696270295070)
A similar, and maybe more general fix could be to "reset" the libraryDependencies to Nil in assemblyShadeSettings (although that's currently only used by the jctools module)