feat(execution): CancelableFuture improvements to get rid of memory leaks + utils#431
Merged
Merged
Conversation
BREAKING CHANGE - zipMap2, zipMap3...zipMap6 have been renamed: - in Coeval they've been renamed to map2, map3, ... map6 - in Task they've been renamed to parMap2, parMap3...parMap6, while map2, map3...map6 have been introduced Change breaks source compatibility.
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 88.86% 89.21% +0.35%
==========================================
Files 341 343 +2
Lines 9400 9459 +59
Branches 1279 1277 -2
==========================================
+ Hits 8353 8439 +86
+ Misses 1047 1020 -27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of
flatMapforCancelableFutureleaks memory (onmaster, not in2.3.x), due to recent changes.This PR fixes it and introduces extra utils, like a
CancelableFuture.asyncbuilder.