Fixes #466 - increase test coverage over 90%#470
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 88.96% 90.12% +1.15%
==========================================
Files 356 353 -3
Lines 9652 8881 -771
Branches 1268 1186 -82
==========================================
- Hits 8587 8004 -583
+ Misses 1065 877 -188 |
Member
|
Thanks @Avasil, let me know if you're done with this PR so I can merge it. |
Collaborator
Author
|
@alexandru I think I'm done for now, if I get more ideas in the future I will do a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466.